Adding User Accounts into a Group

[blue_man51]

What I am trying to achieve is to get a list of users from groupname and then if they are not in groupname2 add them into it, but nothing is happening. Any help would be mush appreciated.

 

PowerShell

$groupmember = Get-ADGroupMember groupname | Get-AdUser foreach ($member in $groupmember) { $getuser = Get-ADPrincipalGroupMembership -Identity $member.SamAccountName | Select-Object name | Where-Object {$_.name -eq 'groupname2' } if($getuser -ne $()) { Add-ADGroupMember -Identity groupname2 -Members $getuser.SamAccountName Write-Output addtogroup } } 

1 2 3 4 5 6 7 8 9 10 11 12 13 14

$groupmember = Get-ADGroupMember groupname | Get-AdUser   foreach ($member in $groupmember) { $getuser = Get-ADPrincipalGroupMembership -Identity $member.SamAccountName | Select-Object name | Where-Object {$_.name -eq 'groupname2' } if($getuser -ne $()) {   Add-ADGroupMember -Identity groupname2 -Members $getuser.SamAccountName   Write-Output addtogroup   } }

• This topic was modified 3 weeks, 3 days ago by blue_man51.
• This topic was modified 3 weeks, 3 days ago by blue_man51.
• This topic was modified 3 weeks, 3 days ago by kvprasoon. Reason: code formatting
• This topic was modified 3 weeks, 3 days ago by kvprasoon. Reason: correct post

[David Schmidtberger]

might be easier to just change your initial groupmember query to include the property memberof. then your check becomes alot simpler, if ($member.memberof -like “*groupname*”) {do something}

then you don’t have to loop through adprinicpalgroupmembership and evaluate every group, should be faster as well

• This reply was modified 3 weeks, 3 days ago by David Schmidtberger.

[kvprasoon]

You don’t need to use Select-Object here as all the objects are passed through the pipeline, Hence Where-Object has access to all the properties.

Hope with $getuser -ne $() you are trying to check if its null or not, the right way to do it is $null -ne $getuser

Try by making above modification to your script.

• This reply was modified 3 weeks, 3 days ago by kvprasoon. Reason: Post correction

[grokkit]

Thanks all I ended going with

PowerShell

foreach ($member in $groupmember) { $getuser = Get-ADPrincipalGroupMembership -Identity $member.SamAccountName | Where-Object {$_.name -eq 'groupname2' } if($null -eq $getuser) { Add-ADGroupMember -Identity groupname2 -Members $member.SamAccountName Write-Output addtogroup } }

1 2 3 4 5 6 7 8 9 10 11 12

foreach ($member in $groupmember) { $getuser = Get-ADPrincipalGroupMembership -Identity $member.SamAccountName | Where-Object {$_.name -eq 'groupname2' } if($null -eq $getuser) {   Add-ADGroupMember -Identity groupname2 -Members $member.SamAccountName   Write-Output addtogroup   } }

• This reply was modified 3 weeks, 2 days ago by grokkit. Reason: HTML parsing fix

[Author]

Posts