Question about Best Practice – IfElse or Switch

[ALombardi01]

Wanting to basically have “options” within a script. If a user is a member of a specific OU (based on their distinguished name) do this task. If they are a member of another OU, do a separate (but nearly identical thing).

I’ve seen some mention using an ElseIf combination but I’ve seen elsewhere that people suggest using Switches. I’m honestly not super familiar with loops and even less so with switches. Anyone have any input/suggestions?

 

PowerShell

Basic idea: If OU = ABC then grab attribute value and place it in ABCtxt document else If OU = DEF then grab attribute value and place it in DEFtxt document else If OU = JKL then grab attribute value and place it in JKLtxt document

1 2 3 4 5 6

Basic idea: If OU = ABC then grab attribute value and place it in ABCtxt document else If OU = DEF then grab attribute value and place it in DEFtxt document else If OU = JKL then grab attribute value and place it in JKLtxt document

etc..

• This topic was modified 2 months ago by ALombardi01. Reason: typo

[Rob Simmers Participant Topics: 15 Replies: 1776 Points: 3,218Rank: Community Hero]

If you are comparing the same variable, then you should use switch:

PowerShell

$ous = 'CN=Marketing,DC=child,DC=company,DC=com', 'CN=Sales,DC=child,DC=company,DC=com', 'CN=Foo,DC=child,DC=company,DC=com' foreach ($ou in $ous) { switch -wildcard ($ou) { '*Sales*' {'Doing stuff for Sales'} '*Marketing*' {'Doing stuff for Marketing'} default {'Doing default stuff because the OU {0} is not defined above' -f $_} } }

1 2 3 4 5 6 7 8 9 10 11 12

$ous = 'CN=Marketing,DC=child,DC=company,DC=com',        'CN=Sales,DC=child,DC=company,DC=com',        'CN=Foo,DC=child,DC=company,DC=com'   foreach ($ou in $ous) {       switch -wildcard ($ou) {         '*Sales*' {'Doing stuff for Sales'}         '*Marketing*' {'Doing stuff for Marketing'}         default {'Doing default stuff because the OU {0} is not defined above' -f $_}     } }

Output:

PowerShell

Doing stuff for Marketing Doing stuff for Sales Doing default stuff because the OU CN=Foo,DC=child,DC=company,DC=com is not defined above

1 2 3

Doing stuff for Marketing Doing stuff for Sales Doing default stuff because the OU CN=Foo,DC=child,DC=company,DC=com is not defined above

Personally rarely use ElseIf logic in Powershell.

[Iain]

I like to use a Switch for this type of thing

PowerShell

<div> <div>$ou = 'z4r'</div> <div>switch ($ou)</div> <div>{</div> <div>    {$_ -eq 'xyz'} {$Text = 'abc'}</div> <div>    {$_ -eq '123'} {$Text = 'jkf'}</div> <div>    {$_ -eq 'abc'} {$Text = 'lmp'}</div> <div>    {$_ -eq 'z4r'} {$Text = 'rst'}</div> <div>}</div> <div></div></div>

1 2 3 4 5 6 7 8 9 10

<div> <div>$ou = 'z4r'</div> <div>switch ($ou)</div> <div>{</div> <div>    {$_ -eq 'xyz'} {$Text = 'abc'}</div> <div>    {$_ -eq '123'} {$Text = 'jkf'}</div> <div>    {$_ -eq 'abc'} {$Text = 'lmp'}</div> <div>    {$_ -eq 'z4r'} {$Text = 'rst'}</div> <div>}</div> <div></div></div>

• This reply was modified 2 months ago by Iain.

[Rob Simmers Participant Topics: 15 Replies: 1776 Points: 3,218Rank: Community Hero]

@Iain

The script block is unnecessary as -eq is the default:

PowerShell

$ou = 'z4r' switch ($ou) { 'xyz' {$Text = 'abc'} '123' {$Text = 'jkf'} 'abc' {$Text = 'lmp'} 'z4r' {$Text = 'rst'} }

1 2 3 4 5 6 7 8 9

$ou = 'z4r'   switch ($ou) {     'xyz' {$Text = 'abc'}     '123' {$Text = 'jkf'}     'abc' {$Text = 'lmp'}     'z4r' {$Text = 'rst'} }

[ALombardi01 Participant Topics: 5 Replies: 10 Points: 87Rank: Member]

Thanks to both of you, @Iain and @Rob

[Author]

Posts